Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send email docs #2432

Merged
merged 6 commits into from
Nov 17, 2023
Merged

feat: Send email docs #2432

merged 6 commits into from
Nov 17, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 15, 2023

What does this PR do?

  • Document /send-email endpoints, refactor into module structure
  • Add a validation layer for requests
  • Move notify functionality to /lib

Regression tests passing on branch ✅ https://github.com/theopensystemslab/planx-new/actions/runs/6882410080

image

@@ -128,33 +128,6 @@ export const fetchPaymentRequestViaProxy = fetchPaymentViaProxyWithCallback(
},
);

export const addGovPayPaymentIdToPaymentRequest = async (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to move this into a shared utils.ts as I was hitting an issue with circular dependencies on the build application.

Copy link

github-actions bot commented Nov 16, 2023

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr marked this pull request as ready for review November 16, 2023 12:16
@DafyddLlyr DafyddLlyr requested a review from a team November 16, 2023 12:16
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good & pizza working as expected 👍

@DafyddLlyr DafyddLlyr merged commit a083beb into main Nov 17, 2023
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/send-email-docs branch November 17, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants